Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI/CD pipelines for AMI cleanup tool #239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fheinecke
Copy link
Contributor

This is a buddy PR for #214 to reduce the PR size. This PR adds GHA PR testing workflows, and GHA release workflows that are backed by Earthfile targets.

This tool uses Earthly for most of the build, review, and release process. We've only used this on a very limited basis for other small projects. I'm using it here (and possibly on future shared-workflow projects) to evaluate it as a possible long-term solution to some of the build issues we've had with Teleport. If it ends up not working well then I can remove it/replace it with our more traditional makefiles/dockerfiles/shell script approach.

@fheinecke fheinecke requested review from a team as code owners March 28, 2024 21:42
Copy link
Contributor

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please not introduce the new tool in the stack that everyone has to learn until we've gone through the proper proposal/design/review process and understood all the pros and cons and what it buys us (which is out of scope of this work IMO).

@fheinecke
Copy link
Contributor Author

@r0mant this isn't exactly new - we're using it here: https://github.com/gravitational/gha-exporter/blob/main/Earthfile

@wadells wadells removed the request for review from a team April 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants